Conversation
… cloning Refactor `enroll_fingerprint_process` to accept references (`&zbus::zvariant::OwnedObjectPath`, `&str`) instead of owned types for `path`, `finger_name`, and `username`. This eliminates the need to clone `String` and `OwnedObjectPath` data on every iteration of the enrollment subscription loop in `AppModel`. * Modified `src/app/fprint.rs`: Updated `enroll_fingerprint_process` signature. * Modified `src/app/mod.rs`: Updated subscription logic to pass references.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What:
The
enroll_fingerprint_processfunction insrc/app/fprint.rswas modified to accept references (&zbus::zvariant::OwnedObjectPath,&str) for its arguments (path,finger_name,username) instead of taking ownership. Consequently, theEnrollmentSubscriptioninsrc/app/mod.rswas updated to pass references to theArc-wrapped data instead of cloning the inner data.🎯 Why:
Previously, the
EnrollmentSubscriptionwould clone theusername,device_path, andfinger_name(deep copy ofStringandOwnedObjectPath) inside the async block for every subscription cycle. This was unnecessary as the data is already held inArcs and can be safely shared by reference for the duration of the async function call.📊 Measured Improvement:
A synthetic benchmark comparing
Arc<String>cloning vs passing&strshowed a massive performance difference (orders of magnitude faster with zero allocations for the reference approach). While the enrollment process itself is IO-bound by user interaction, removing these allocations reduces CPU and memory overhead during the subscription setup.PR created automatically by Jules for task 17165333057639684485 started by @jotuel